Add sampling support for get_policy_events_* methods #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sampling parameter is present in context and has a value, use it for building the URL
With sampling support I'm able to keep consistency with UI policy event timeline.
This is the same case that get_policy_events_duration: With sampling I'm able to keep consistency with UI policy event timeline.
|
It looks like build is failing because PYTHON_SDC_TEST_ACCESS_KEY is not set, but I'm not quite sure how to fix this. |
|
@nestorsalceda thanks for the contribution! Changes make sense, we're trying to understand the problem with the build, it seems fairly unrelated with your changes... |
|
The travis failure is because the tests depend on credentials that access our staging environment to test the various APIs. Your fork of the repo doesn't have those credentials, so it couldn't run the tests. However, I did run the two tests by hand using your fork and they passed, so I'll go ahead and merge. Thanks so much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI is using sampling for aggregating several events, and I would like to keep this consistency when using the API.
I have added a sampling parameter to context, and I use its value for building the URL.
Thanks!